ci: retry build dir cleanup on Windows#807
Merged
Merged
Conversation
evindj
suggested changes
Jul 5, 2026
Contributor
Author
|
Thank you for reviewing @evindj; I've added the failure message as suggested! |
evindj
approved these changes
Jul 5, 2026
wgtmac
approved these changes
Jul 12, 2026
Member
|
Thank you, @abnobdoss and @evindj! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Retry
rm -rfcleanup in the CMake CI helper scripts. Windows can briefly keep a just-built executable or DLL open, which can make cleanup fail even after the build and tests have passed.build_example.shretries before configuring and still letsmkdirfail if the directory remains, so it will not build in a half-deleted tree.build_iceberg.shretries after the build and does not fail an otherwise successful job if final cleanup is still blocked.